Closed branyip closed 1 year ago
@mapsam Sounds good! Will get some input from the team to confirm if we want to go forward with the patch versioning.
I tried to make the least invasive change by just swapping the Exception base class, so functionality should be unchanged. I don't think the stack traces are necessary as long as our error messages are sufficient (which they seem to be from my spot tests).
I tried to make the least invasive change by just swapping the Exception base class, so functionality should be unchanged. I don't think the stack traces are necessary as long as our error messages are sufficient (which they seem to be from my spot tests).
👍 agree, and since the error messages aren't changing, if someone is relying on the raw text of an exception it's almost certainly the message text and not the stack trace. Let's move forward with a patch release!
Context
This work removes confusing stack traces from error outputs.
Tests
Some before/after spot tests
Before: estimate-area, invalid geojson
After: estimate-area, invalid geojson
Before: estimate-area, json schema validation error
After: estimate-area, json schema validation error
Before: no token
After: no token
Before: delete, tileset not found
After: delete, tileset not found