The example "High density points for data visualization (data reduction)" seems to be invalid

mapbox / tilesets-cli

CLI for interacting with the Mapbox Tilesets API and Mapbox Tiling Service

https://docs.mapbox.com/mapbox-tiling-service

BSD 2-Clause "Simplified" License

125 stars 27 forks source link

The example "High density points for data visualization (data reduction)" seems to be invalid #38

Closed 0xGuybrush closed 4 years ago

0xGuybrush commented 4 years ago

I've just installed the Tilesets CLI and trying to add a recipe to an existing tileset. If I copy the example recipe from the docs for High density points for data visualization (data reduction), I get an error on validation

Steps to reproduce

Create example recipe file as per docs:

{
  "version": 1,
  "layers": {
    "dots": {
      "source": "mapbox://tileset-source/{username}/high-density-points-data",
      "minzoom": 0,
      "maxzoom": 15,
      "tiles": {
        "limit": [
          [ "lowest_where_in_distance", true, 50000, null ]
        ]
      }
    }
  }
}

Swap in my username and tileset name and save
Run tilesets validate-recipe example.json

Expected outcome

Tileset recipe validates correctly

Current outcome

Validation fails with an error:

{"valid": false, "errors": ["recipe.tiles.limit attribute value \"null\" is not a string."]}

Version info

This is usign tilesets v0.3.3 (cloned from master)

brsbl commented 4 years ago

Thanks for opening this ticket @another-dave ! We're currently working on a large revamp of all of our recipe examples and will include updating this recipe as part of that work.

brsbl commented 4 years ago

We recently released a big revamp of our recipe examples: https://docs.mapbox.com/help/troubleshooting/tileset-recipe-examples/, so I'm closing this ticket.

0xGuybrush commented 4 years ago

We recently released a big revamp of our recipe examples: https://docs.mapbox.com/help/troubleshooting/tileset-recipe-examples/, so I'm closing this ticket.

Hi @brsbl, thanks for following up & will dig into the new examples when I get a chance.

Just an FYI that you've a broken link for sample data download under (NYC points of interest — reducing feature density)

Under "Download the data you'll use to create the tileset", the Download data button links through to https://mts-recipe-examples.s3.amazonaws.com/nyc_pois.ldgeojson and gives an AWS S3 error:

<Error>
    <Code>NoSuchBucket</Code>
    <Message>The specified bucket does not exist</Message>
    <BucketName>mts-recipe-examples</BucketName>
    <RequestId>E4F85C6603569577</RequestId>
    <HostId>
        bl7+iGoid6INZwb7BeZbxEOgNKqNNsGK0sK3s4/3Brmjzc48U7fVb6X3aEN9hyRMoXbOCf9kyrM=
    </HostId>
</Error>

millzpaugh commented 4 years ago

@another-dave - fixing this link now! will let you know when it's updated on the site.

millzpaugh commented 4 years ago

confirmed this download link works now! https://docs.mapbox.com/mapbox-tiling-service/examples/points-of-interest/