search

mapbox / tiny-sdf

Browser-side SDF font generator
http://mapbox.github.io/tiny-sdf/
BSD 2-Clause "Simplified" License
575 stars 58 forks source link

Cropped last row #42

Closed boris-ulyanov closed 2 years ago

boris-ulyanov commented 2 years ago

Hi!

I noticed that bottom row of the bitmap is cropped for all characters:

original

Did not understand where the error, but if increase glyphHeight by one on line https://github.com/mapbox/tiny-sdf/blob/main/index.js#L59 :

fixed

Checked on chrome/firefox windows/linux/android

mourner commented 2 years ago

I thought this was already fixed by https://github.com/mapbox/tiny-sdf/pull/33, are you sure this is reproducible with the latest version of TinySDF? I don't see it clipped on the current demo: https://mapbox.github.io/tiny-sdf/

boris-ulyanov commented 2 years ago

Strange, right now I see this on the demo page (on default params):

demo2

Same result reproduced local on latest version

mourner commented 2 years ago

Fixed by #43?