Cleanup blockers - Githubissues

mapbox / tippecanoe

Build vector tilesets from large collections of GeoJSON features.

BSD 2-Clause "Simplified" License

2.72k stars 432 forks source link

Cleanup blockers #552

Open e-n-f opened 6 years ago

e-n-f commented 6 years ago

There should probably be some general cleanup of the codebase and directory structure. But be careful not to break outstanding PRs that should be merged eventually after some more work:

https://github.com/mapbox/tippecanoe/pull/303 Nested attributes
https://github.com/mapbox/tippecanoe/pull/468 Shapefile input
https://github.com/mapbox/tippecanoe/pull/506 Data type cleanup
https://github.com/mapbox/tippecanoe/pull/533 Use vtzero
https://github.com/mapbox/tippecanoe/pull/514 Detect features within features
https://github.com/mapbox/tippecanoe/pull/551 Mergeable features
https://github.com/mapbox/tippecanoe/pull/539 JSON form for command-line options

springmeyer commented 6 years ago

👍 Thanks for creating this @ericfischer. Once those merge I think we should plan to:

Move all command line tools to subdirectory. How about./bin?
Move all source code into subdirectory. How about src?
Move all third party/vendored code into subdirectory. How about ./deps or ./third_party?
Move documentation into ./docs. The main files left at the root would be README.md, CHANGELOG.md, LICENSE.md, Makefile + configurations for travis/codecov/etc.

How does that sound?

nhoover commented 6 years ago

Thanks for not forgetting these outstanding PRs! Still hoping for #514.