mapbox / tokml

Convert GeoJSON to KML.
http://mapbox.github.io/tokml/
BSD 2-Clause "Simplified" License
189 stars 91 forks source link

upgrade strxml to fix warnings related to tap included in build #31

Open kriscarle opened 7 years ago

kriscarle commented 7 years ago

This was still using the original version of strxml that included tap in dependences. All the tests are passing again.

This is mainly to fix security warnings coming from old versions of uglify etc. that are pulled in by this repo https://snyk.io/test/npm/tokml/0.4.0

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 05bb2a39361c2f9c9dc8ea61ddd9a16f50771d06 on kriscarle:master into 91c3fa5fb256ef74307847e21de53dbb1f043349 on mapbox:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b1bb13f2b4bd4e5effc200466aa8930cbf80b47e on kriscarle:master into 91c3fa5fb256ef74307847e21de53dbb1f043349 on mapbox:master.

bobi7 commented 6 years ago

Will there be any work done on this?

kszafran commented 5 years ago

+1

Now that nsp check no longer works and npm audit does not allow ignoring vulnerabilities as of now (not even mentioning yarn audit...) this is pretty problematic.

kriscarle commented 5 years ago

@kszafran @bobi7 It doesn't seem like Mapbox is still using or maintaining this code, so I went ahead and converted this PR to a fork, and published v0.5.0 here https://www.npmjs.com/package/@maphubs/tokml

kszafran commented 5 years ago

@kriscarle I actually switched to your fork yesterday. Thanks for publishing it to npm!