Removes deprecated static_visitor to avoid msvc C4996 compiler warning

mapbox / variant

C++11/C++14 Variant

BSD 3-Clause "New" or "Revised" License

371 stars 101 forks source link

Removes deprecated static_visitor to avoid msvc C4996 compiler warning #163

Closed maxhora closed 6 years ago

maxhora commented 6 years ago

We're getting annoying C4996 msvc compiler warning stating that deprecated constraint is found by compiler("was declared deprecated"). In combination with compiler flag to treat any warning as error it fails CI builds. Can we just remove deprecated static_visitor? Thanks

artemp commented 6 years ago

@MaxRis - looks good to me, thanks!

daniel-j-h commented 6 years ago

Hm, this is a breaking change and needs a v2 release, no?

artemp commented 6 years ago

@daniel-j-h - that's the thinking - variant 2.0.