search

mapbox / wagyu

A general library for geometry operations of union, intersections, difference, and xor
Other
166 stars 33 forks source link

-Weffc++ flags pointer data members without copy ctor and assignment ctor override #73

Closed springmeyer closed 7 years ago

springmeyer commented 7 years ago

This warning is one of the less helpful of -Weffc++ (Added in #70), but since we set -Werror we should ideally find a way to avoid it:

include/mapbox/geometry/wagyu/bound.hpp:20:8: error: ‘struct mapbox::geometry::wagyu::bound<long int>’ has pointer data members [-Werror=effc++]
 struct bound {
        ^
include/mapbox/geometry/wagyu/bound.hpp:20:8: error:   but does not override ‘mapbox::geometry::wagyu::bound<long int>(const mapbox::geometry::wagyu::bound<long int>&)’ [-Werror=effc++]
include/mapbox/geometry/wagyu/bound.hpp:20:8: error:   or ‘operator=(const mapbox::geometry::wagyu::bound<long int>&)’ [-Werror=effc++]
cc1plus: all warnings being treated as errors
springmeyer commented 7 years ago

Fixed in 5325272 which will land in #75