mapbox / windows-builds

DEPRECATED! build scripts for mapnik dependencies, mapnik, node-mapnik, node, libosmiom, osmium-tool
38 stars 22 forks source link

Upgrade deps for Mapnik #65

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

In order to stay in sync with with unix build for Mapnik @BergWerkGIS - could you create a branch that follows https://github.com/mapnik/mapnik-packaging/commit/47fbe17536d92734488064fc129b5e5701d62566?

refs https://github.com/mapnik/mapnik-packaging/pull/194

springmeyer commented 8 years ago

https://github.com/mapnik/mapnik-packaging/pull/194 is merged. @BergWerkGIS would be great if you can hit this tomorrow for windows.

wilhelmberg commented 8 years ago

@springmeyer harfbuzz is giving me a hard time.

We are using this cmake file.

At first there were errors about missing src/hb-ot-shape-complex-sea.cc and its ragel file. But this file has been removed from harfbuzz: https://github.com/behdad/harfbuzz/commit/21cb08a417f1203523191192d6a342e8cd0ea14c

I removed hb-ot-shape-complex-sea.cc from the cmake file: https://github.com/mapbox/windows-builds/blob/master/patches/harfbuzz-v1.0.6-cmake-patch.diff

harfbuzz compiled then, but mapnik is failing with an error, that seems related:

"c:\mb\windows-builds-64\packages\mapnik-master\mapnik-gyp\build\mapnik.sln" (default target) (1) ->
       "c:\mb\windows-builds-64\packages\mapnik-master\mapnik-gyp\build\csv.vcxproj.metaproj" (default target) (2) ->
       "c:\mb\windows-builds-64\packages\mapnik-master\mapnik-gyp\build\mapnik.vcxproj" (default target) (24) ->
       (Link target) ->
         harfbuzz.lib(hb-ot-shape.cc.obj) : error LNK2019: unresolved external symbol "struct hb_ot_complex_shaper_t const _hb_ot
       _complex_shaper_use" (?_hb_ot_complex_shaper_use@@3Uhb_ot_complex_shaper_t@@B) referenced in function "struct hb_ot_comple
       x_shaper_t const * __cdecl hb_ot_shape_complex_categorize(struct hb_ot_shape_planner_t const *)" (?hb_ot_shape_complex_cat
       egorize@@YAPEBUhb_ot_complex_shaper_t@@PEBUhb_ot_shape_planner_t@@@Z) [c:\mb\windows-builds-64\packages\mapnik-master\mapn
       ik-gyp\build\mapnik.vcxproj]
         lib\mapnik.dll : fatal error LNK1120: 1 unresolved externals [c:\mb\windows-builds-64\packages\mapnik-master\mapnik-gyp\
       build\mapnik.vcxproj]
wilhelmberg commented 8 years ago

Added harfbuz.lib to target csv in mapnik-gyp -> same error.

wilhelmberg commented 8 years ago

ok, getting further. More changes to harfbuzz cmake file are required.

wilhelmberg commented 8 years ago

mapnik builds now, but again a lot of

'mapnik-index' is not recognized as an internal or external command

although it gets copied into mapnik-sdk\bin.

test cases:    45 |    44 passed | 1 failed
assertions: 20956 | 20953 passed | 3 failed
..\..\test\unit\datasource\geojson.cpp(279): FAILED:
  CHECK( mapnik::util::exists(filename + ".index") )
with expansion:
  false
with messages:
  1
  0
Completed in 0.068211s
geojson completed in 0.070395s
'mapnik-index' is not recognized as an internal or external command,
operable program or batch file.
-------------------------------------------------------------------------------
geojson
  GeoJSON extra properties
-------------------------------------------------------------------------------
..\..\test\unit\datasource\geojson.cpp(77)
...............................................................................
..\..\test\unit\datasource\geojson.cpp(342): FAILED:
  CHECK( mapnik::util::exists(filename + ".index") )
with expansion:
  false
with messages:
  1
  0
Completed in 0.053318s
geojson completed in 0.055498s
'mapnik-index' is not recognized as an internal or external command,
operable program or batch file.
-------------------------------------------------------------------------------
geojson
  GeoJSON ensure input fully consumed and throw exception otherwise
-------------------------------------------------------------------------------
..\..\test\unit\datasource\geojson.cpp(77)
...............................................................................
..\..\test\unit\datasource\geojson.cpp(394): FAILED:
  CHECK( mapnik::util::exists(filename + ".index") )
with expansion:
  false
with messages:
  1
  0
wilhelmberg commented 8 years ago

node-mapnik@mapnik-index:

548 passing (9s)
  1 pending
springmeyer commented 8 years ago

@BergWerkGIS great that node-mapnik is working.

although it gets copied into mapnik-sdk\bin.

Is the problem perhaps that mapnik-sdk\bin is not on PATH?

wilhelmberg commented 8 years ago

Is the problem perhaps that mapnik-sdk\bin is not on PATH?

Y, that was missing. Building an updated deps package ATM.

wilhelmberg commented 8 years ago

binary deps package updated.