search

mapbox / windows-builds

DEPRECATED! build scripts for mapnik dependencies, mapnik, node-mapnik, node, libosmiom, osmium-tool
38 stars 22 forks source link

Upgrade deps #68

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

Need to match https://github.com/mapnik/mapnik-packaging/pull/197 as well as icu upgrade mentioned in #67

wilhelmberg commented 8 years ago

Stuck at harfbuzz at the moment:

c:\mb\windows-builds-64\packages\harfbuzz\src\hb-buffer-private.hh(51): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\mb\windows-builds-64\packages\harfbuzz\src\hb-buffer-private.hh(52): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\mb\windows-builds-64\packages\harfbuzz\src\hb-buffer-private.hh(67): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
springmeyer commented 8 years ago

Looks like this change may have broken compilation with vs 2015: https://github.com/behdad/harfbuzz/commit/167c3271778cd1a8c4433b9d2230901ce17c099e#diff-69538b0bfd6ad743ba41ec2f883af18f /cc @fanc999

springmeyer commented 8 years ago

hoping that https://github.com/behdad/harfbuzz/commit/f94c0ecbb1488138d3ec3b9d6d9fb78113dfee4f (and therefore upgrading to 1.1.1) will solve the compile error.

wilhelmberg commented 8 years ago

Upgrading to harfbuzz@1.1.1 and changing at bit of the CMake file solved the compile.

Although getting some test crashes:

Assertion in file gdaldrivermanager.cpp, line 415

Hope this gets merged into master soon: Enable Build of HarfBuzz under Visual Studio using NMake Makefiles: https://github.com/behdad/harfbuzz/pull/164/files

wilhelmberg commented 8 years ago

Merged https://github.com/mapbox/windows-builds/pull/69