search

mapbox / windows-builds

DEPRECATED! build scripts for mapnik dependencies, mapnik, node-mapnik, node, libosmiom, osmium-tool
38 stars 22 forks source link

Harfbuzz built with `-HB_NO_MT` #70

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

It looks like harfbuzz is being built with -HB_NO_MT. Let's plan to strip this from the cmake file we use as per https://github.com/behdad/harfbuzz/issues/190

/cc @BergWerkGIS

springmeyer commented 8 years ago

@BergWerkGIS - could you prioritize this? It should be an easy fix (I presume). Basically -HB_NO_MT I think is being set in the cmake file we download dynamically and it needs to be removed.

wilhelmberg commented 8 years ago

Done https://github.com/mapbox/windows-builds/commit/a565fc97d937e1dd0aa9a7dc76be2cca3a8d47aa

Updated the binary deps packages (for FASTBUILD=1) too:

Came across a new libpng build error on the way, but appears only with x64, not x86. Tracking here https://github.com/mapbox/windows-builds/issues/71

springmeyer commented 8 years ago

@BergWerkGIS thank you. Can https://github.com/mapnik/node-mapnik/issues/568 be closed now? See also https://github.com/mapnik/node-mapnik/issues/578 which will require another SDK update after https://github.com/mapbox/windows-builds/commit/63022b0a26ba3e2f5e88ea45009ac2a8ada2fc50

wilhelmberg commented 8 years ago

Can mapnik/node-mapnik#568 be closed now?

:+1:

See also mapnik/node-mapnik#578 which will require another SDK update after 63022b0

working on it.