libpng: error MSB3073: :VCEnd" exited with code 1

[wilhelmberg]

occurs only with x64 builds, not with x86:

       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\vstudio.sln" (default target) (1) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngunknown\pngunknown.vcxproj.metaproj" (default target) (7) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngunknown\pngunknown.vcxproj" (default target) (9) ->
       (CustomBuildStep target) ->
         C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: The command ""
       c:\mb\windows-builds-64\packages\libpng\projects\vstudio\x64\Release\pngunknown.exe" --strict --default --touch "x64\Relea
       se\pngunknown.out" ../../../pngtest.png\r [c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngunknown\pngunknown.
       vcxproj]
       C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: :VCEnd" exited w
       ith code 1. [c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngunknown\pngunknown.vcxproj]

       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\vstudio.sln" (default target) (1) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngstest\pngstest.vcxproj.metaproj" (default target) (6) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngstest\pngstest.vcxproj" (default target) (11) ->
         EXEC : ../../../contrib/pngsuite/basn3p01.png(4,0) opaque component error :  [c:\mb\windows-builds-64\packages\libpng\pr
       ojects\vstudio\pngstest\pngstest.vcxproj]
         C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: The command ""
       c:\mb\windows-builds-64\packages\libpng\projects\vstudio\x64\Release\pngstest.exe" --strict --log --touch "x64\Release\png
       stest.out" ../../../contrib/pngsuite/basn0g01.png ../../../contrib/pngsuite/basn0g02.png ../../../contrib/pngsuite/basn0g0
       4.png ../../../contrib/pngsuite/basn0g08.png ../../../contrib/pngsuite/basn0g16.png ../../../contrib/pngsuite/basn2c08.png
        ../../../contrib/pngsuite/basn2c16.png ../../../contrib/pngsuite/basn3p01.png ../../../contrib/pngsuite/basn3p02.png ../.
       ./../contrib/pngsuite/basn3p04.png ../../../contrib/pngsuite/basn3p08.png ../../../contrib/pngsuite/basn4a08.png ../../../
       contrib/pngsuite/basn4a16.png ../../../contrib/pngsuite/basn6a08.png ../../../contrib/pngsuite/basn6a16.png ../../../contr
       ib/pngsuite/ftbbn0g01.png ../../../contrib/pngsuite/ftbbn0g02.png ../../../contrib/pngsuite/ftbbn0g04.png ../../../contrib
       /pngsuite/ftbbn2c16.png ../../../contrib/pngsuite/ftbbn3p08.png ../../../contrib/pngsuite/ftbgn2c16.png ../../../contrib/p
       ngsuite/ftbgn3p08.png ../../../contrib/pngsuite/ftbrn2c08.png ../../../contrib/pngsuite/ftbwn0g16.png ../../../contrib/png
       suite/ftbwn3p08.png ../../../contrib/pngsuite/ftbyn3p08.png ../../../contrib/pngsuite/ftp0n0g08.png ../../../contrib/pngsu
       ite/ftp0n2c08.png ../../../contrib/pngsuite/ftp0n3p08.png ../../../contrib/pngsuite/ftp1n3p08.png\r [c:\mb\windows-builds-
       64\packages\libpng\projects\vstudio\pngstest\pngstest.vcxproj]
       C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: :VCEnd" exited w
       ith code 1. [c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngstest\pngstest.vcxproj]

       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\vstudio.sln" (default target) (1) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngvalid\pngvalid.vcxproj.metaproj" (default target) (5) ->
       "c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngvalid\pngvalid.vcxproj" (default target) (12) ->
         C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: The command ""
       c:\mb\windows-builds-64\packages\libpng\projects\vstudio\x64\Release\pngvalid.exe" --touch "x64\Release\pngvalid.out"\r [c
       :\mb\windows-builds-64\packages\libpng\projects\vstudio\pngvalid\pngvalid.vcxproj]
       C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(203,5): error MSB3073: :VCEnd" exited w
       ith code 1. [c:\mb\windows-builds-64\packages\libpng\projects\vstudio\pngvalid\pngvalid.vcxproj]

[wilhelmberg]

2 points so far:

• in the post build step of pngstests.vcxproj arguments to pngstest.exe expect it to be run from projects/vstudio/Release but it is run from projects/vstudio/x64/Release
• but even after adjusting the paths x64 tests don't pass

x64

run from projects/vstudio/x64/Release (with adjusted parameter paths).

pngstest.exe --strict --log --touch "x64\Release\pngste
st.out" ../../../../contrib/pngsuite/basn0g01.png ../../../../contrib/pngsuite/basn0g02.png ../../../../contrib/pngsuite/basn0g0
4.png ../../../../contrib/pngsuite/basn0g08.png ../../../../contrib/pngsuite/basn0g16.png ../../../../contrib/pngsuite/basn2c08.
png ../../../../contrib/pngsuite/basn2c16.png ../../../../contrib/pngsuite/basn3p01.png ../../../../contrib/pngsuite/basn3p02.pn
g ../../../../contrib/pngsuite/basn3p04.png ../../../../contrib/pngsuite/basn3p08.png ../../../../contrib/pngsuite/basn4a08.png
../../../../contrib/pngsuite/basn4a16.png ../../../../contrib/pngsuite/basn6a08.png ../../../../contrib/pngsuite/basn6a16.png ..
/../../../contrib/pngsuite/ftbbn0g01.png ../../../../contrib/pngsuite/ftbbn0g02.png ../../../../contrib/pngsuite/ftbbn0g04.png .
./../../../contrib/pngsuite/ftbbn2c16.png ../../../../contrib/pngsuite/ftbbn3p08.png ../../../../contrib/pngsuite/ftbgn2c16.png
../../../../contrib/pngsuite/ftbgn3p08.png ../../../../contrib/pngsuite/ftbrn2c08.png ../../../../contrib/pngsuite/ftbwn0g16.png
 ../../../../contrib/pngsuite/ftbwn3p08.png ../../../../contrib/pngsuite/ftbyn3p08.png ../../../../contrib/pngsuite/ftp0n0g08.pn
g ../../../../contrib/pngsuite/ftp0n2c08.png ../../../../contrib/pngsuite/ftp0n3p08.png ../../../../contrib/pngsuite/ftp1n3p08.p
ng

../../../../contrib/pngsuite/basn0g01.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn0g01.png
PASS: --strict ../../../../contrib/pngsuite/basn0g02.png
PASS: --strict ../../../../contrib/pngsuite/basn0g04.png
PASS: --strict ../../../../contrib/pngsuite/basn0g08.png
../../../../contrib/pngsuite/basn0g16.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn0g16.png
PASS: --strict ../../../../contrib/pngsuite/basn2c08.png
PASS: --strict ../../../../contrib/pngsuite/basn2c16.png
../../../../contrib/pngsuite/basn3p01.png: image read failed: internal error handling cHRM->XYZ
FAIL: --strict ../../../../contrib/pngsuite/basn3p01.png
../../../../contrib/pngsuite/basn3p02.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn3p02.png
../../../../contrib/pngsuite/basn3p04.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn3p04.png
PASS: --strict ../../../../contrib/pngsuite/basn3p08.png
../../../../contrib/pngsuite/basn4a08.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn4a08.png
../../../../contrib/pngsuite/basn4a16.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/basn4a16.png
../../../../contrib/pngsuite/basn6a08.png(26,1) alpha component error:
 sRGB-rgb+alpha(255,31,8,213) on background sRGB-gray(66) ->
       sRGB-gray(139)
  not: sRGB-gray(122).
 The error happened when reading the original file with this format.
FAIL: --strict ../../../../contrib/pngsuite/basn6a08.png
TMP350.png --strict: sRGB: too many profiles
TMP350.png: read of new file failed: sRGB: too many profiles
FAIL: --strict ../../../../contrib/pngsuite/basn6a16.png
PASS: --strict ../../../../contrib/pngsuite/ftbbn0g01.png
PASS: --strict ../../../../contrib/pngsuite/ftbbn0g02.png
../../../../contrib/pngsuite/ftbbn0g04.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/ftbbn0g04.png
../../../../contrib/pngsuite/ftbbn2c16.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/ftbbn2c16.png
../../../../contrib/pngsuite/ftbbn3p08.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/ftbbn3p08.png
PASS: --strict ../../../../contrib/pngsuite/ftbgn2c16.png
../../../../contrib/pngsuite/ftbgn3p08.png: image read failed: internal error handling cHRM->XYZ
FAIL: --strict ../../../../contrib/pngsuite/ftbgn3p08.png
TMP610.png --strict: sRGB: duplicate sRGB information ignored
TMP610.png: read of new file failed: sRGB: duplicate sRGB information ignored
FAIL: --strict ../../../../contrib/pngsuite/ftbrn2c08.png
PASS: --strict ../../../../contrib/pngsuite/ftbwn0g16.png
../../../../contrib/pngsuite/ftbwn3p08.png: image read failed: internal error handling cHRM->XYZ
FAIL: --strict ../../../../contrib/pngsuite/ftbwn3p08.png
../../../../contrib/pngsuite/ftbyn3p08.png: image read failed: internal error handling cHRM->XYZ
FAIL: --strict ../../../../contrib/pngsuite/ftbyn3p08.png
../../../../contrib/pngsuite/ftp0n0g08.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/ftp0n0g08.png
../../../../contrib/pngsuite/ftp0n2c08.png --strict: gAMA: duplicate
FAIL: --strict ../../../../contrib/pngsuite/ftp0n2c08.png
../../../../contrib/pngsuite/ftp0n3p08.png: image read failed: internal error handling cHRM->XYZ
FAIL: --strict ../../../../contrib/pngsuite/ftp0n3p08.png
TMP715.png --strict: sRGB: too many profiles
TMP715.png: read of new file failed: sRGB: too many profiles
FAIL: --strict ../../../../contrib/pngsuite/ftp1n3p08.png

x86

run from projects/vstudio/Release. tests succeed.

pngstest.exe --strict --log --touch "Release\pngstest.out"
../../../contrib/pngsuite/basn0g01.png ../../../contrib/pngsuite/basn0g02.png ../../../contrib/pngsuite/basn0g04.png ../../../co
ntrib/pngsuite/basn0g08.png ../../../contrib/pngsuite/basn0g16.png ../../../contrib/pngsuite/basn2c08.png ../../../contrib/pngsu
ite/basn2c16.png ../../../contrib/pngsuite/basn3p01.png ../../../contrib/pngsuite/basn3p02.png ../../../contrib/pngsuite/basn3p0
4.png ../../../contrib/pngsuite/basn3p08.png ../../../contrib/pngsuite/basn4a08.png ../../../contrib/pngsuite/basn4a16.png ../..
/../contrib/pngsuite/basn6a08.png ../../../contrib/pngsuite/basn6a16.png ../../../contrib/pngsuite/ftbbn0g01.png ../../../contri
b/pngsuite/ftbbn0g02.png ../../../contrib/pngsuite/ftbbn0g04.png ../../../contrib/pngsuite/ftbbn2c16.png ../../../contrib/pngsui
te/ftbbn3p08.png ../../../contrib/pngsuite/ftbgn2c16.png ../../../contrib/pngsuite/ftbgn3p08.png ../../../contrib/pngsuite/ftbrn
2c08.png ../../../contrib/pngsuite/ftbwn0g16.png ../../../contrib/pngsuite/ftbwn3p08.png ../../../contrib/pngsuite/ftbyn3p08.png
 ../../../contrib/pngsuite/ftp0n0g08.png ../../../contrib/pngsuite/ftp0n2c08.png ../../../contrib/pngsuite/ftp0n3p08.png ../../.
./contrib/pngsuite/ftp1n3p08.png

PASS: --strict ../../../contrib/pngsuite/basn0g01.png
PASS: --strict ../../../contrib/pngsuite/basn0g02.png
PASS: --strict ../../../contrib/pngsuite/basn0g04.png
PASS: --strict ../../../contrib/pngsuite/basn0g08.png
PASS: --strict ../../../contrib/pngsuite/basn0g16.png
PASS: --strict ../../../contrib/pngsuite/basn2c08.png
PASS: --strict ../../../contrib/pngsuite/basn2c16.png
PASS: --strict ../../../contrib/pngsuite/basn3p01.png
PASS: --strict ../../../contrib/pngsuite/basn3p02.png
PASS: --strict ../../../contrib/pngsuite/basn3p04.png
PASS: --strict ../../../contrib/pngsuite/basn3p08.png
PASS: --strict ../../../contrib/pngsuite/basn4a08.png
PASS: --strict ../../../contrib/pngsuite/basn4a16.png
PASS: --strict ../../../contrib/pngsuite/basn6a08.png
PASS: --strict ../../../contrib/pngsuite/basn6a16.png
PASS: --strict ../../../contrib/pngsuite/ftbbn0g01.png
PASS: --strict ../../../contrib/pngsuite/ftbbn0g02.png
PASS: --strict ../../../contrib/pngsuite/ftbbn0g04.png
PASS: --strict ../../../contrib/pngsuite/ftbbn2c16.png
PASS: --strict ../../../contrib/pngsuite/ftbbn3p08.png
PASS: --strict ../../../contrib/pngsuite/ftbgn2c16.png
PASS: --strict ../../../contrib/pngsuite/ftbgn3p08.png
PASS: --strict ../../../contrib/pngsuite/ftbrn2c08.png
PASS: --strict ../../../contrib/pngsuite/ftbwn0g16.png
PASS: --strict ../../../contrib/pngsuite/ftbwn3p08.png
PASS: --strict ../../../contrib/pngsuite/ftbyn3p08.png
PASS: --strict ../../../contrib/pngsuite/ftp0n0g08.png
PASS: --strict ../../../contrib/pngsuite/ftp0n2c08.png
PASS: --strict ../../../contrib/pngsuite/ftp0n3p08.png
PASS: --strict ../../../contrib/pngsuite/ftp1n3p08.png
Release\pngstest.out: open failed

[wilhelmberg]

Decided to just build libpng and not the tests that come with it.

mapnik and node-mapnik tests should cover our png use cases pretty well.

[springmeyer]

great work @BergWerkGIS

[jbowler]

Great work? Where's that picture of an ostrich with its head in the sand?

Best indications are that on x86 with a Release build VS2015 cannot compile code correctly. The fix is not to use it. Given the errors above bugs that result will be almost undetectable until the world explodes.