search

mapcentia / geocloud2

The GC2 framework helps you build a spatial data infrastructure quickly and easily. Powered using open source components for a scalable solution focused on freedom rather than fees.
https://www.osgeo.org/projects/gc2-vidi/
GNU Affero General Public License v3.0
148 stars 67 forks source link

Fix grammar issue causing jshint to fail #29

Closed snario closed 8 years ago

snario commented 8 years ago

I was getting this issue after a recent commit.

Running "jshint:all" (jshint) task

   public/js/store.js
   1245 | value: (records.length === 1 ) ? (Ext.decode(records[0].data.meta)[v.name] || v.default) : null
                                                                                                                                                             ^ Expected an identifier and instead saw 'default' (a reserved word).
   1255 | checked: (records.length === 1 ) ? ((Ext.decode(records[0].data.meta)[v.name] !== undefined) ? Ext.decode(records[0].data.meta)[v.name] : v.default) : false
                                                                                                                                                                                                                         ^ Expected an identifier and instead saw 'default' (a reserved word).
   1273 |  value: (records.length === 1 ) ? ((Ext.decode(records[0].data.meta)[v.name]) || v.default) : null
                                                                                                                                                               ^ Expected an identifier and instead saw 'default' (a reserved word).

>> 3 errors in 24 files
Warning: Task "jshint:all" failed. Use --force to continue.

Aborted due to warnings.
ERROR: Service 'gc2core' failed to build: The command '/bin/sh -c cd /var/www/geocloud2 &&  npm install &&  grunt production' returned a non-zero code: 3
mapcentia commented 8 years ago

It was caused by jslint was using ec3. Its now using ec5 where "default" as object property name is allowed. Fixed this last night