search

mapcomm / common-ground_map

An enhanced leaflet map made for re-use (highly commented, built openly) used to show community groups and find "common ground"
http://mapping.community
1 stars 3 forks source link

UX: drop fields in panel if data is null or empty #13

Closed kidwellj closed 7 years ago

kidwellj commented 7 years ago

For fields like URL, Facebook, Twitter, etc. can we put in some code to test whether the field is null of empty and if so exclude completely from display? So some might just be "Name" and "Description" or whatever.

danhillcode commented 7 years ago

Just updated this so should be ok now for undefined fields however there is one of them that isn't playing ball Laurencekirk Development Trust near Aberdeen, not sure what the url is in there.

danhillcode commented 7 years ago

Also I didn't alter the description as it is being filled as suggested in last meeting.

kidwellj commented 7 years ago

Happy to report that Laurencekirk is "null" for url. :)

On 7 Jul 2017, at 15:50, Daniel James Hill notifications@github.com wrote:

Just updated this so should be ok now for undefined fields however there is one of them that isn't playing ball Laurencekirk Development Trust near Aberdeen, not sure what the url is in there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mapcomm/common-ground_map/issues/13#issuecomment-313703793, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwQ0JjdWONT9lu-nnCuryVOYMaec5zGks5sLkWjgaJpZM4OMTFy.