mapeditor / rs-tiled

Reads files from the Tiled editor into Rust
https://crates.io/crates/tiled
MIT License
268 stars 103 forks source link

Make TiledError non-exhaustive #124

Closed aleokdev closed 2 years ago

aleokdev commented 2 years ago

That way backwards-compatibility will be preserved when adding new error types.

bjorn commented 2 years ago

Hmm, is this just adding #[non_exhaustive] before the pub enum TiledError and possibly also the pub enum ParseTileError lines? Is there anything else to keep in mind?

If it's just that I'd say we should do this for 0.10 already.

aleokdev commented 2 years ago

Yes, it's just that.