search

mapeditor / rs-tiled

Reads files from the Tiled editor into Rust
https://crates.io/crates/tiled
MIT License
268 stars 103 forks source link

Contain all layer types in an enum #131

Closed aleokdev closed 2 years ago

aleokdev commented 2 years ago

Closes #130 & supersedes #53. Fits all layer types into a single LayerType enum and places all common data (ID, name, properties, etc) into a struct.

aleokdev commented 2 years ago

Btw, why is it still marked as draft, even though it appears to compile and test out fine?

Just because I wasn't 100% sure of the final interface. Group layers will get their own PR, since they weren't implemented even before these changes.

bjorn commented 2 years ago

+218 −168... always the same, if you clean and remove lots of duplicate code, you still usually end up with more code! :S

aleokdev commented 2 years ago

Okay, I swear this is the last time I ask you to re-review :p

Edit: Nevermind, build's broken x_x