search

mapeditor / rs-tiled

Reads files from the Tiled editor into Rust
https://crates.io/crates/tiled
MIT License
268 stars 102 forks source link

Initial support for WangSets #226

Closed josebaMdeL closed 2 years ago

josebaMdeL commented 2 years ago

Initial support for WangSets.

I have added it by reading the TMX Map Format documentation and following some examples, but note that:

  1. My code doesn't feet too well on the current crate organization (I will need some help with this).
  2. I don't really know how WangSets work or how are they used inside Tiled (I would like someone who knows them to test it).
  3. I don't really know what I'm doing in general (no way to fix this at the moment ;) )
bjorn commented 2 years ago

Just a small bit of feedback from me for now, I would suggest you turn your Wang set example into a test instead, since it demonstrates nothing new as an example, but it would be good to cover the loading of Wang sets with a test.

josebaMdeL commented 2 years ago

Just a small bit of feedback from me for now, I would suggest you turn your Wang set example into a test instead, since it demonstrates nothing new as an example, but it would be good to cover the loading of Wang sets with a test.

Done!

josebaMdeL commented 2 years ago

Updated with proposed changes. I just forget to change the WangSetType's doc comment, but it will be corrected for the next commit.