search

mapeditor / rs-tiled

Reads files from the Tiled editor into Rust
https://crates.io/crates/tiled
MIT License
268 stars 102 forks source link

Add hexside_length for newer tmx. #313

Closed darkautism closed 1 month ago

darkautism commented 1 month ago

Some of tmx (new version?) file has this attarbute. And i found other tmx library also has this attribute. We need this!

aleokdev commented 1 month ago

Please also update CHANGELOG.md and select the next branch as the merge target.

darkautism commented 1 month ago

I didn't know which should been in the CHANGELOG.md, so I cannot fix this conflicts .

aleokdev commented 1 month ago

Alright, I'll fix it

aleokdev commented 1 month ago

Had to rebase your branch to merge into next, please for next time base everything onto the next branch instead

aleokdev commented 1 month ago

GH Actions froze because of the CI skip on the previous commit lol

bjorn commented 1 month ago

Whoops, I missed that a u32 was used. Actually this property isn't unsigned, even if there may not be an actual use for negative values... (opened https://github.com/mapeditor/rs-tiled/pull/316).