search

mapeditor / tiled-to-godot-export

Tiled plugins for exporting Tilemaps and Tilesets to Godot 3 format
149 stars 35 forks source link

Potential Fix for Folders Not Working #25

Closed camdrit closed 2 years ago

camdrit commented 3 years ago

This should partially address #13 specifically in regards to folders not working. Essentially I added a function to recursively get the parent path for nested nodes and additionally added a condition for layer.isGroupLayer to recognize folders.

Tested to work on layers nested multiple groups deep, would be great if someone could review a case with object layers as these are not used by me in my current project.

Other than that, feedback/cleanup on my implementation is definitely desired....running on very little sleep after trying to find a good solution for exporting Tiled maps to performant Godot scenes (thanks very much for this extension, it works fantastically in this regard!) so this may look messy.

bjorn commented 3 years ago

There seems to be at least one remaining parent: ".", that likely needs to be adjusted to call getLayerParentage, just after } else if (layer.isObjectLayer) {.

Other than that the change seems reasonable, but I haven't tested it,

MikeMnD commented 2 years ago

I think this is outdated and should be closed.