Get meta for Area2D objects from the object itself instead of the layer

mapeditor / tiled-to-godot-export

Tiled plugins for exporting Tilemaps and Tilesets to Godot 3 format

149 stars 35 forks source link

Get meta for Area2D objects from the object itself instead of the layer #43

Closed nerochiaro closed 2 years ago

nerochiaro commented 2 years ago

At the moment, export of meta for Area2D objects is broken, see #42

This PR fixes the problem by exporting the objects's meta instead of the layer's meta.

It also disables setting meta on the child CollisionShape2D, since there's no clear way to decide what should go in there. Maybe anything with a prefix like godot:child:meta: could go in there, but it did not seem right, so I left it out of the PR for now.

bjorn commented 2 years ago

Looks good to me. I've requested a review from @mcarpenter622 since this was added in #33, to make sure it does not break an intended behavior.

nerochiaro commented 2 years ago

@mcarpenter622 I see you have been active on PR #46 recently. Could you please also comment/approve on this PR (which also corrects some issues related to code you wrote) when you got a minute ? It is much simpler and most has been reviewed by @bjorn already. Thank you !