Tiled Map Editor freezes all the time

[souvinix]

Hello, i dont know why but my Tiled freezes the whole time. I reseted my computer and I often reinstalled Tiled but nothing works. Pls help. And other programs works well. :(

[bjorn]

Has this always been happening, or did it start happening after upgrading to a specific version? And what do you mean with "freezes"? Does it lock up, no longer responding? Or does it crash? What is your operating system?

[X-Ray-Jin]

I am not sure if it is the same thing but I face an issue that tiled crashes. On windows ("Tiled stopped working") and mac. However I wasn't able to reproduce it in a consistent way. It sometimes happens when loading a map or tileset, sometimes when switching map or tileset.

[tamkcr]

Updated to 2018.12.22 I am experiencing a similar issue, only happens at random occasionally on map load so far. 1.1.6 was stable on my end previously.

[bjorn]

@X-Ray-Jin If Tiled crashes on macOS, a dialog should pop up that also includes a backtrace. That is usually extremely helpful in identifying the cause of a crash, so please make sure to provide the information next time it happens. Unfortunately Windows doesn't do this.

@tamkcr Random occasion crashes are always hard to pin down. Please let me know when you see any kind of pattern. In the meantime, you could also try if Tiled 1.2.1 is more stable than the development snapshot.

[souvinix]

I have fixed the problem for myself. I stopped many programs and looked if it works then, I found the program. The program is called "Nahimic", this is a very important audio program for my laptop but i dont see a relationship to Tiled and nahimic. I dont understand why but it only works if nahimic is not active. I tried very often so I can say it is save.

Am Di., 22. Jan. 2019, 22:42 hat Thorbjørn Lindeijer < notifications@github.com> geschrieben:

Has this always been happening, or did it start happening after upgrading to a specific version? And what do you mean with "freezes"? Does it lock up, no longer responding? Or does it crash? What is your operating system?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bjorn/tiled/issues/2060#issuecomment-456555524, or mute the thread https://github.com/notifications/unsubscribe-auth/AZTMXAOh9xCw5J1mst7T0B3MKiCqdkFSks5vF3evgaJpZM4aNbQI .

[tamkcr]

Upon further usage I think it may have something to do with loading .json maps (csv) saved from older versions, not entirely sure since I can't reproduce it reliably but it doesn't seem to happen otherwise.

[tjuravich]

I've been receiving this error on each usage on 1.10.1, here is a gist with the full crash report: https://gist.github.com/tjuravich/f7427528ba5d59cac692e995db3ca3dd

Happy to debug further

[bjorn]

@tjuravich Hmm, this is a 4 years old issue and the real cause has remained unclear, I should probably have closed it a long time ago.

In any case, the problem you're running into is unrelated and can only be happening since Tiled 1.4, when projects were added. The report you've uploaded (thanks!) seems to indicate the following Tiled functions being part of a one minute hang:

  11  Tiled::ProjectModel::folderScanned(Tiled::FolderEntry*) + 346 (libtilededitor.dylib + 1768442) [0x1115a3bfa]
  11  Tiled::FileSystemWatcher::addPaths(QList<QString> const&) + 314 (libtiled.dylib + 32090) [0x10ce5ed5a]
  11  QFileSystemWatcher::addPaths(QList<QString> const&) + 467 (QtCore + 2401827) [0x10efb5623]

This indicates that a project folder finished its background scan, and now Tiled is trying to add all paths (which were recursively found in the project) to the file system watcher, so that it can decide when to re-scan that project folder. Apparently, either adding paths is very slow, or it found a very large amount of paths in your project folder. Do you actually have a huge project, or did you maybe add your home folder directly to your project?

We could probably protect against this case by limiting the number of paths that Tiled will watch. I can try to reproduce the problem and do some tests to see at which point the performance problem becomes noticeable.

[eishiya]

Do you actually have a huge project, or did you maybe add your home folder directly to your project?

This is a tangent, but I've been wondering, how does Tiled handle recursive or repeated symlinks? Does it keep track of resolved paths it's already looked at, so that it doesn't look at the same directory more than once? Since scripts have access to Project directories now, this has been a worry of mine - is this something scripts should watch out for to avoid infinite loops?

[bjorn]

This is a tangent, but I've been wondering, how does Tiled handle recursive or repeated symlinks? Does it keep track of resolved paths it's already looked at, so that it doesn't look at the same directory more than once?

For watching project folders, this is handled by using the canonical path to check whether a folder was already processed, which has all symlinks resolved:

https://github.com/mapeditor/tiled/blob/a56b5a250fd6a7c622219771dcd7b9732ec444e4/src/tiled/projectmodel.cpp#L495-L500

Since scripts have access to Project directories now, this has been a worry of mine - is this something scripts should watch out for to avoid infinite loops?

Scripts doing recursive iteration might also have to rely on FileInfo.canonicalPath to avoid going into an endless loop.