search

mapeditor / tiled

Flexible level editor
https://www.mapeditor.org/
Other
11.01k stars 1.74k forks source link

Nicer lua exporter ouput #338

Closed svenstaro closed 11 years ago

svenstaro commented 11 years ago

Currently, the lua output is fairly unreadable. A few sensible line breaks should be added to improve this.

bjorn commented 11 years ago

Are you using Windows and a version of Tiled older then 0.8? I fixed a bug in Tiled 0.8.0 that caused the newlines to always be in UNIX format, which won't show up when you open the resulting file in for example notepad on Windows.

Other than that, the Lua exported file already has a lot of sensible newlines, so if you believe there should be additional line breaks please provide more details. For example, the layer data has a line break after each row of tiles, which I believed to be a sensible thing to do.

svenstaro commented 11 years ago

This doesn't appear to be the case. I'm on Tiled 0.8.1 on Arch Linux. Our files come out like this: https://raw.github.com/svenstaro/gamejam/2ffa9fd36f01af0e477b9dcaea66c4a96d106865/GGJ2013/data/levels/level0.lua

bjorn commented 11 years ago

Ah, right, I forgot about change b51b98734acdb8199d3222efd3cae2b7840125b8 which fixes the initialization of LuaTableWriter::m_suppressNewlines. If it happens to be initialized to true you'll see that.

So, if that's annoying you then please compile Tiled from master. I'll anyway be releasing that as Tiled 0.9 Real Soon Now.