search

mapeditor / tiled

Flexible level editor
https://www.mapeditor.org/
Other
11.22k stars 1.76k forks source link

Nothing happens when I click [Map > Map Properties...] #3806

Open manake opened 1 year ago

manake commented 1 year ago

Describe the bug Nothing happens when I click [Map > Map Properties...].

To Reproduce Steps to reproduce the behavior:

  1. Click on [Map > Map Properties...].

Expected behavior Either it should be grayed out or something should happen.

Media

https://github.com/mapeditor/tiled/assets/6874031/0d94d1ec-0d22-4367-887a-690759539b17

Specifications:

eishiya commented 1 year ago

The Map Properties were successfully opened. The reason it looks like nothing happened is because you already had them open.

Edit: These are the Map Properties, visible in your video: image

manake commented 1 year ago

Thanks, I realized this eventually too.

But in such case it should have a "tick" icon to indicate that it's already opened:

2
eishiya commented 1 year ago

The Properties panel already has such a checkmark. image Such checkmarks are generally used for things that have a binary state such as on/off, which doesn't make sense for the content of the Properties panel, which can be in many states.

The Map Properties and Tileset Properties menu items are really only there because there's no good way to "select" Maps and Tilesets for viewing in the properties panel the way you can with Tiles, Objects, Layers, etc. #3101 is about making the Map and Tileset properties easier to find, and perhaps if a good solution is found there, these menu items could be removed entirely.

An alternative solution would be to briefly flash the panel, similar to how activating already activated windows works in some programs. I don't know whether this is possible in Qt.