search

mapeditor / tiled

Flexible level editor
https://www.mapeditor.org/
Other
11.27k stars 1.76k forks source link

Added "Tileset > Edit Tileset Image Parameters..." action #4034

Open bjorn opened 3 months ago

bjorn commented 3 months ago

This makes the functionality easier to discover. Previously editing the tileset image parameters was only possible by clicking the value of the Image property in the Properties view, and then the appearing "Edit" button.

bjorn commented 3 months ago

@CodiumAI-Agent /review

(just curious what feedback it might have)

CodiumAI-Agent commented 3 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Code Duplication
The method `updateActions` is introduced to replace `updateAddRemoveActions`, but the new method is almost identical to the old one with the addition of enabling/disabling `mEditTilesetParameters`. Consider refactoring to avoid duplication and enhance maintainability. UI Consistency
Ensure that the new menu actions added for editing tileset parameters are consistent with existing UI design and user expectations. This includes checking alignment, spacing, and interaction behavior within the menu.
bjorn commented 3 months ago

Oh well, the agent failed to understand a line was added to a function rather than a "duplicate" being added. For a moment I thought it might have caught the duplication between TilesetEditor::editTilesetParameters and TilesetParametersEdit::buttonClicked, but no, I think the latter was likely not in the context.