search

mapero / esphome-hcpbridge

esphome component to connect to Hörmann Garage Door
MIT License
27 stars 10 forks source link

Merge into ESPHome Core? #5

Open BradleyFord opened 10 months ago

BradleyFord commented 10 months ago

Would it be possible to have this added directly into ESPHome?

Also it is really great that this in ESPHome, it is now super easy to setup and get running.

mapero commented 10 months ago

I guess it needs some more work on the modbus stuff. Needs to use the modbus component from esphome. Currently it uses the modbus code from the hcpbridge.

I definitely have this on the list, but currently I am a little time constraint. Since it is working fine at the moment, this is not my highest priority project ;)

jkaberg commented 6 months ago

Now that https://github.com/esphome/esphome/pull/4874#event-12888024585 is merged this should possibly be easier?

14yannick commented 2 months ago

I had a look on the esphome modbus component. but I think at the moment not all needed functionality are present there. In the source code there is mentioned that the needed modbus fuction Read write multiple register is not implemented. This implementation is definitively above my capability. READ_WRITE_MULTIPLE_REGISTERS = 0x17, // not implemented