search

mapfish / mapfish-print-v2

MapFish Print allows printing maps as PDFs and is used by mapfish.org, geoserver extension and core-genet work.
http://www.mapfish.org/doc/print/
GNU General Public License v3.0
0 stars 11 forks source link

Support custom pdf layer name (sent in request JSON parameter "pdfLayerName") #22

Closed tiago-s-vieira-alb closed 3 months ago

tiago-s-vieira-alb commented 4 months ago

In the following example you can see, the retro-compatibility in red and the custom layer name in green: image

If this PR is approved, we would like to see the geoserver and mapfish print documentation updated please: https://docs.geoserver.org/stable/en/user/extensions/printing/protocol.html http://www.mapfish.org/doc/print/protocol.html Add in "Layers Params" chapter the optional field "pdfLayerName".

jodygarnett commented 3 months ago

Oh, please update the docs also in your PR - if we do not maintain them as we go we end up with a mess trying to figure out what works or does not work.

https://mapfish.github.io/mapfish-print-v2/configuration.html

I think just documenting your new parameter should be fine, the geoserver docs link to this suff also.

tiago-s-vieira-alb commented 3 months ago

We've updated the documentation, and we've done a few manual tests and it's ok. Once you release a new version, I can create a PR in geoserver to point to this mapfish version and update the documentation there too.

jodygarnett commented 3 months ago

Thanks @tiago-s-vieira-alb I appreciate your professionalism.

jodygarnett commented 3 months ago

Thanks, this is in the map-print 2.3.1 release (see https://github.com/mapfish/mapfish-print-v2/releases/tag/release%2F2.3.1 and osgeo maven repo)