search

mapfit / iOS-sdk

Other
4 stars 1 forks source link

Licensing for this SDK Should be Apache 2.0 with Attribution to Mapzen #1

Open msmollin opened 6 years ago

msmollin commented 6 years ago

Hello! I'm the primary maintainer of the Mapzen & Nextzen iOS SDKs, the latter of which is a fork of the former that I'm still actively developing (https://github.com/nextzen/ios). It appears this is a fork of one of those SDKs. I'm guessing given the age of the commits here, it's the Mapzen SDK.

The Mapzen iOS SDK was licensed under the Apache 2.0 license. Per that license, if you copy large parts of the code, and thereby create a derivative work, you are required to maintain that license for those copied parts of the code, state the changes you made to other parts of that code, and include the apache 2.0 license for the original code. You can read about that here: https://github.com/mapzen/ios/blob/master/LICENSE.md. Also it would be neat to attribute the original authors.

The parts I'm considering copied include:

Most of the Location Manager https://github.com/mapzen/ios/blob/master/MapzenSDK/LocationManager.swift#L92 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/MFTClasses/MFTLocationProvider.swift#L108

Large portions of the gesture recognizer delegate code https://github.com/mapzen/ios/blob/master/MapzenSDK/MZMapViewController.swift#L50 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/MFTClasses/MFTMapViewGestrues.swift#L13

Significant portions of the MFTMapView https://github.com/mapzen/ios/blob/master/MapzenSDK/MZMapViewController.swift#L1236 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/MFTClasses/MFTMapView.swift#L1509

Extensions to Tangram: https://github.com/mapzen/ios/blob/master/MapzenSDK/TangramExtensions.swift#L14 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/Extensions/TangramExtensions.swift#L16

Bundle Extensions: https://github.com/mapzen/ios/blob/master/MapzenSDK/BundleExtensions.swift#L9 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/Extensions/BundleExtension.swift#L11

Large portions of Themes work: https://github.com/mapzen/ios/blob/master/MapzenSDK/Themes.swift#L20 https://github.com/mapfit/iOS-sdk/blob/master/iOS-SDK/Helper/MFTThemes.swift#L29

I appreciate the new work you've done with the code and look forward to the continued success of Mapfit. However I believe this is a derivative work given the above, and as such falls under all the requirements of the Apache 2.0 License. Please re-license this appropriately, and attribute the original authors appropriately. Thank you!

msmollin commented 6 years ago

Bumping this. Would like to see this addressed.