search

mapgears / scribeui

http://scribeui.org
MIT License
27 stars 15 forks source link

Groups not removed #64

Closed cbourget closed 10 years ago

cbourget commented 10 years ago

When removing many groups at once, sometimes, some of them are not removed. This is because a POST request is made for each group to be deleted and each of those request open and edit the file where groups are stored. If this file is still open from a preceding request, then the modifications are overwritten by that last request and some groups are not removed.

Making a single POST request with all the groups to be removed would fix that bug.

dmorissette commented 10 years ago

Another possible fix could be to setup a locking mechanism for all file modifications in Scribe. That wuld require more work but would prevent other similar problems in the future in other areas of the code

jlap commented 10 years ago

In this particular case cbourget's suggested solution makes more sense, as all the groups are moved and deleted all at once in the UI, so it actually makes very little sense to make several post requests.

A locking mecanism might be necessary in the future, but not for this issue. If the cloud aspect of scribeui is developped more (ex. two persons collaborating on the same map at the same time) we will have to find a solution.

dmorissette commented 10 years ago

Fine with me.

jlap commented 10 years ago

I think this was fixed in the pyramid merge, it is not an issue anymore.