maphew / apt

command line package manager for Osgeo4W
http://trac.osgeo.org/osgeo4w/wiki/pkg-apt
GNU General Public License v2.0
4 stars 2 forks source link

md5 namespace collision #13

Closed maphew closed 9 years ago

maphew commented 9 years ago

There is a function md5 and a global variable md5. One of them has to go.

amr66 commented 9 years ago

It's a good praxis to "hide" variables by using underscores, may be that's a way? If all global variables would be marked that way, identifying them in the code will be much easier. So i'd vote for __md5!

maphew commented 9 years ago

...also discovered there's a standard md5 module! Commit ba079337e6927a1938386134bf3d7b41475f06aa changes the md5 command to apt hascheck.

a quick and standardized visual indicator of global variables is a good idea. I tend not to like underscores, don't like the finger stretch when typing, but don't have any better ideas. Punting this part of the discussion down the road; it'll get it's own issue ticket.

amr66 commented 9 years ago

hashcheck or hascheck?