mapiacompany / capacitor-codepush

Capacitor plugin for CodePush
http://appcenter.ms
Other
152 stars 64 forks source link

Maybe bug: User prompted for Filesystem access #12

Closed lincolnthree closed 3 years ago

lincolnthree commented 3 years ago

Thanks so much for getting this plugin converted to Capacitor!

Description

After installing and configuring the code-push plugin, doing some preliminary testing seems to show that users are required to accept the following permission prompt:

image

Is this normal, or have I done something wrong? It seems this plugin should be able to function without writing to External storage, but I am not an Android permissions expert.

Reproduction

  1. Ensure update is available in AppCenter
  2. Run the app with this plugin installed
  3. Call codePushUtil.sync()

Additional Information

(The more info the faster we will be able to address it!)

leo6104 commented 3 years ago

It might be related with https://github.com/ionic-team/capacitor-plugins/issues/248 .

Can you try with @capacitor/filesystem 0.5.1 ?

lincolnthree commented 3 years ago

@leo6104 I think this solved the issue. Running some final tests but I think it's working without prompt on 0.5.1.

lincolnthree commented 3 years ago

Closing this as I believe it is resolved. Thanks!