search

mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.
MIT License
39 stars 15 forks source link

[Requirements] 6. Get Image Thumbnail #17

Closed Rubix982 closed 3 years ago

Rubix982 commented 3 years ago

Is your feature request related to a problem? Please describe. This issue deals with the 6th requirement from the PRD for getting the thumbnails of images from the API.

Describe the solution you'd like The base requirements are,

  1. Takes image key as an argument, returns a URL for the thumbnail
  2. Options for thumbnail size, ranging from 320 to 2048 width

Describe alternatives you've considered NA

Additional context NA

Rubix982 commented 3 years ago

@cbeddow clarification needed for this. The requirement says "thumbnail size, ranging from 320 to 2048 width", but the API only gives fields for sizes 256, 1024, 2048 fields, https://www.mapillary.com/developer/api-documentation/#image.

Should we implement some image resizing logic, or should this requirement be fixed?

OmarMuhammedAli commented 3 years ago

@cbeddow clarification needed for this. The requirement says "thumbnail size, ranging from 320 to 2048 width", but the API only gives fields for sizes 256, 1024, 2048 fields, https://www.mapillary.com/developer/api-documentation/#image.

Should we implement some image resizing logic, or should this requirement be fixed?

I implemented this requirement based on the API specification. Any other image resolution is not accepted by the API so I believe this should be rephrased to: "resolutions available are: 256, 1024, 2048" I requested a related edit on the PRD as well

Rubix982 commented 3 years ago

Acknowledged. [256, 1024, 2048] to go with until further update from @cbeddow.

cbeddow commented 3 years ago

Thanks yes, my mistake (I think old API had those dimensions but not the new one). Good to go with 256/1024/2048!