mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.
MIT License
39 stars 15 forks source link

Implement Client class for tailored interactions with the Mapillary API #34

Closed OmarMuhammedAli closed 3 years ago

OmarMuhammedAli commented 3 years ago

API communication utility addition

Pull Request Type

  1. πŸ† Enhancements - does this PR add a new feature or requirement? This resolves the issue #28

  2. πŸ“œ Documentation - does this PR add or contribute to the documentation The whole utility including the module, class, and methods has been documented using docstrings.

Purpose

Include the purpose of this Pull Request. For example,

Why?

Having all the API interactions handled in a single spot extremely simplifies those interactions for future development. Further enhancements will be applied to this utility to further ease the API communication (e.g. create date formatting functions, output parsing utils, etc...)

Feedback required over

What kind of feedback do you require from this PR, if any? For example,

Or something else entirely that you have in mind

Mentions

@Rubix982 and @cbeddow, I'd love your input, opinions, and critiques on the PR.

References

Rubix982 commented 3 years ago

Reviewed! But I think needs minor changes to improve the code quality a bit more. I think it would be great if we should discuss this on-call. Texting and typing take a lot of time, it.

But overall, this is down really nice. Pretty awesome!