Rubix982 commented 3 years ago

Refactor /config/api/

Pull Request Type

📜 Documentation - changed adjustable fields and properties, to With the following properties,
🐛 Bug Fix - properties and fields were confused, and checking was being done for properties, where there was no option for fields
🏠 Internal - fields are now retrieved as functions instead of being hardcoded and repeated everywhere, for the DRY principle

Why?

The /config/api/ will be depended on by the client layer, and this is important so the entire logic of dealing with correct fields occurs within the /config/api/ itself

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach

Mentions

@cbeddow a few changes in the logic for long-term thinking. What do you think?
@OmarMuhammedAli same as above. What do you think?

OmarMuhammedAli commented 3 years ago

This looks good to me! Will leave for @OmarMuhammedAli to glance at and merge when he's ready. Let me know if otherwise you'd like me to just merge these @OmarMuhammedAli

Thanks @cbeddow ! I'll be merging ASAP

Rubix982 commented 3 years ago

Squashing/rebasing is working very weirdly.

@OmarMuhammedAli review with changes required.

Rubix982 commented 3 years ago

@gmelodie can you check out the latest commit, please? Thank you!

Rubix982 commented 3 years ago

Found a few bugs inconsistent with how the adapters should be working with. @gmelodie, ideas please.

mapillary / mapillary-python-sdk