mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.
MIT License
39 stars 15 forks source link

[Utilities] Proposal, `time.py`, `format.py` #44

Closed Rubix982 closed 3 years ago

Rubix982 commented 3 years ago

[Utilities] Proposal, time.py, format.py

Pull Request Type

Purpose

Implementing some utilities

Why?

time.py

Time utility to convert date format into a UNIX timestamp.

The code to me felt redundant and the quality can be approved, but it works as expected for now, and can manage 6 + 1 formats of the date, making it flexible, starting from Year to Second (not ms).

format.py

Functionality for converting some data types into mainly GeoJSON, for merging GeoJSON

This component helps to convert data structure formats. I also added functionality for merging GeoJSONS when building req#2 thinking it might need multiple endpoints - which it didn't in the end, but it is helpful if want to 'join' GeoJSON based on some key in the features.

Feedback required over

Feedback required when

Whenever feasible

Mentions

Rubix982 commented 3 years ago

Ayeee, @gmelodie ! Thank you. :D

Rubix982 commented 3 years ago

@gmelodie your review, please

@OmarMuhammedAli Can I improve this bit of logic even further?

Rubix982 commented 3 years ago

@gmelodie review plisssssssssss