search

mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.
MIT License
37 stars 15 forks source link

[Controller] Introduces Rules For Kwargs Checking #57

Closed Rubix982 closed 3 years ago

Rubix982 commented 3 years ago

Introduced "rules" for controller/, helps to implement DRY for various requirements and be a single point of failure given wrong keyword arguments are passed.

Compliments #56

Rubix982 commented 3 years ago

@OmarMuhammedAli I implemented the thumbnail_size_check before I saw your exception class - maybe we can refactor it in a new PR?

OmarMuhammedAli commented 3 years ago

@Rubix982 Yep! let's do that

Rubix982 commented 3 years ago

Good work! Would suggest clarifying the kwargs, what they are for each check, what are they based on, and how they may contradict one another

Thanks!

For the "what they are for each check, what are they based on" suggestion, what should I add? Will the explanation in the DocStrings of controllers/ be enough? How can I clarify the kwargs more?

OmarMuhammedAli commented 3 years ago

Thanks!

For the "what they are for each check, what are they based on" suggestion, what should I add? Will the explanation in the DocStrings of controllers/ be enough? How can I clarify the kwargs more?

Oh I've just seen the explanations in controller/. They're more than enough 😄

Rubix982 commented 3 years ago

@OmarMuhammedAli okieeesss.

Should I self-merge, or you?

OmarMuhammedAli commented 3 years ago

Just merged!

Rubix982 commented 3 years ago

Ly!