Closed OmarMuhammedAli closed 3 years ago
For the files,
mapillary.py
on spotverify.py
makes sense for the formatting. I realized we do not have DocStrings over there. Created an issue for this, #69 format.py
I like the examples, good job!feature.py
everything makes sense and is easy to read. Nice!filter.py
most pep8 styling issues, but the code looks better. Thank you!I believe this is good to be merged.
Applied suggestions and fixed a bug with date_to_unix_timestamp
@cbeddow and @Rubix982, let me know if there are any further modifications you'd like to be applied, and if this is okay to be merged!
Approval from my side. :+1:
Merging to use utils on my current PR
Req no.8 Implementation: Get filtered features within a bbox
Purpose and Proposed Changes:
Feedback required over
What kind of feedback do you require from this PR, if any? For example,
Feedback required when
Whenever possible 😄
Mentions
@Rubix982, @gmelodie , and @cbeddow. Would love to discuss your thoughts and feedback!
References (OPTIONAL)
Mapillary API V4