mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.

MIT License

37 stars 15 forks source link

[Requirement] Get filtered images and sequences within a bounding box #71

Closed OmarMuhammedAli closed 3 years ago

OmarMuhammedAli commented 3 years ago

Implementation for #18 for getting relevant images and sequences within a bbox

Pull Request Type

🏆 Enhancements - A user now can simply retrieve all the images and sequences filtered with custom filters within a bbox
📜 Documentation - Inline documentation added for relevant functions, controllers and utilities.

Purpose and proposed changes

Implement images_in_bbox driver function for getting filtered images within a bbox
Implement sequences_in_bbox driver function for getting filtered sequences of images within a bbox
Implement get_images_in_bbox_controller to hold the business logic for both drivers
Implement several filters and verifying functions to help achieve the main goal of the PR

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach
critique on design
A review of copy

Feedback required when

ASAP

References

Coverage tiles docs

Rubix982 commented 3 years ago

Merging for now as to prep for the meeting today and making sure to test everything and remove bug, if any.