mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.

MIT License

37 stars 15 forks source link

[Requirement] Get All Detections for Image Key / Map Feature Key #83

Closed Rubix982 closed 2 years ago

Rubix982 commented 2 years ago

Pull Request Type

🏆 Enhancements - finishes requirement#4, 5. This will close #15 and this will close #16

Purpose

Requirement#4, 5

Why?

Requirement#4, 5

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach

Mentions

@cbeddow does the implementation look proper? I've added documentation and tested it out 6-7 times, let me know if there are any changes. Also, the requirement mentioned in #15 and #16 do not mention if the output should be filtered, so I haven't added filtering yet because I was unsure what parameters to filter for
@OmarMuhammedAli anything I can do better in this code?

References

Check out the test.env for the map_feature_id and the image_id I used for testing
Getting Started with the new Mapillary API v4