mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.

MIT License

41 stars 16 forks source link

[Requirements] 9. Get Features In shape/GeoJSON #94

Closed Rubix982 closed 3 years ago

Rubix982 commented 3 years ago

Pull Request Type

🏆 Enhancements - It introduces some changes,
- Finishes requirement#9.1 (geojson as input) and requirement#9.2 (shape as input)
- Introduces the GeoJSON class
- Installs the shapely package
- Vector Tiles API Adapter refactoring for DRY purpose
- Small bug fixes in filter.py (found when preparing presentation)
- Converted some requirements to output GeoJSON instead of dict. This does not break forward compatibility
- Small bug fixes for image_close_to and image_looking_at (found when preparing presentation). GeoJSON compatibility made
- Documentation taking a large chunk of changes

On merge, it should close #20

Purpose

Changes made keeping in mind the 9th requirement and the presentation with Manuel.

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach

Mentions

@cbeddow does the implementation look proper? I shared some
@OmarMuhammedAli this inadvertently became too large because of bug fixes and styling changes here and there for the presentation, but I think it is reviewable and understandable in the changes made

References

Bbox Polygon

OmarMuhammedAli commented 3 years ago

Resolving merge conflicts then merging