mapillary / mapillary-python-sdk

A Python 3 library built on the Mapillary API v4 to facilitate retrieving and working with Mapillary data.

MIT License

37 stars 15 forks source link

[Requirements] 12. Save GeoJSON data locally #95

Closed OmarMuhammedAli closed 2 years ago

OmarMuhammedAli commented 2 years ago

Save GeoJSON data locally

Pull Request Type

🏆 Enhancements - This is an implementation of the 12th requirement of the PRD which enables the user to save GeoJSON data locally to .geojson and .csv formats. Other formats may be added in the future.

Feedback required over

A quick pair of :eyes: on the code
Discussion on the technical approach
critique on design
A review of copy

Rubix982 commented 2 years ago

@OmarMuhammedAli should I merge this will you be adding new commits?

OmarMuhammedAli commented 2 years ago

@OmarMuhammedAli should I merge this will you be adding new commits?

I'm still implementing some of the changes that @cbeddow mentioned, so I'll be adding new commits

OmarMuhammedAli commented 2 years ago

@Rubix982 @cbeddow, I've introduced several changes in both controllers. Can you re-review this PR?

Rubix982 commented 2 years ago

@OmarMuhammedAli sure!

OmarMuhammedAli commented 2 years ago

Applied suggested changes. @cbeddow and @Rubix982, what do you think?

Rubix982 commented 2 years ago

Seems great, @OmarMuhammedAli! I think it can be merged.

cbeddow commented 2 years ago

Looks good! merging