search

mapillary / mapillary_tools

Command line tools for processing and uploading Mapillary imagery
BSD 2-Clause "Simplified" License
256 stars 134 forks source link

Use GPS time for videos if the difference with creation time is too big #659

Open malconsei opened 9 months ago

malconsei commented 9 months ago

Some cameras reset their internal clock when the battery runs out, or otherwise get out of sync with the world clock.

  1. Change PointWithFix to a more generic GpsPoint which contains GPS timestamps.
  2. If available, save the GPS timestamp of the last point in the JSON description.
  3. Upon upload, use it as timestamp of the CAMM track.
  4. Server-side, use this timestamp if it's more than 86400s (1 day) apart from the video creation time.
ptpt commented 9 months ago

LGTM.

The only concern is the ground speed added in mapillary_tools/geotag/camm_parser.py. It is used to determine if a GPS point is noisy or not (and noisy points and corresponding frames will be removed). If the velocity values were populated incorrectly, then normal GPS points would be mistakenly removed too. Need to test this change on real CAMM videos.

facebook-github-bot commented 3 months ago

Hi @malconsei!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

eneerhut commented 1 month ago

Keeping an eye on this one. It would great to have GPS time set as the default to avoid capture time data issues when the camera resets its clock. This is a common issue on GoPros.