search

mapkon / oc-conversion-tools

openxdata openclinica form conversion tools
code.openxdata.org
Other
8 stars 4 forks source link

Translated Text should hold Item Group Header and Subheader for all Items in an Item Group #61

Closed tomhickerson closed 12 years ago

tomhickerson commented 12 years ago

In OpenClinica, for all questions that are grouped and have ItemGroup Header and ItemGroup Sub Header, the question text should be framed from concatenating "ItemGroup Header - ItemGroup SubHeader - Question Text" other than "Item Header - Item SubHeader - Question Text". This should give the converted xform questions better context on what group they belong too since they are not grouped in the converted xform.

In the event that the item header/subheader are null, the item-group header/subheader is put in its place.

tomhickerson commented 12 years ago

New version of the metadata with the above change:

<ItemDef OID="I_CCAC_CCA_DISEASE" Name="CCA_DISEASE" DataType="integer" Length="1" SASFieldName="CCA_DISE" Comment="Disease/Illness/Condition" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC1">
                <Question OpenClinica:QuestionNumber="Q2">
                    <TranslatedText>
                    Events since last visit or since birth - Since birth or last visit, has your baby suffered/is suffering from any disease/illness/condition?
                    </TranslatedText>
                </Question>
                <CodeListRef CodeListOID="CL_259"/>
            </ItemDef>
            <ItemDef OID="I_CCAC_CCA_CONSULT" Name="CCA_CONSULT" DataType="text" Length="14" SASFieldName="CCA_C010" Comment="consultation for illness" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC1">
                <Question>
                    <TranslatedText>
                    Q2a If yes, - where was he/she taken for consultation?
                    </TranslatedText>
                </Question>
                <OpenClinica:MultiSelectListRef MultiSelectListID="MSL_260"/>
            </ItemDef>
            <ItemDef OID="I_CCAC_CCA_NAME" Name="CCA_NAME" DataType="text" Length="200" SASFieldName="CCA_NAME" Comment="name of the personn for the consultation" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC1">
                <Question>
                    <TranslatedText>
                    Q2a If yes, - What is the name of this person or clinic/hospital?
                    </TranslatedText>
                </Question>
            </ItemDef>

tomhickerson commented 12 years ago

Previous version of the metadata, without the change:

<ItemDef OID="I_CCAC_CCA_DISEASE" Name="CCA_DISEASE" DataType="integer" Length="1" SASFieldName="CCA_DISE" Comment="Disease/Illness/Condition" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC1">
                <Question OpenClinica:QuestionNumber="Q2">
                    <TranslatedText>
                    Events since last visit or since birth - Since birth or last visit, has your baby suffered/is suffering from any disease/illness/condition?
                    </TranslatedText>
                </Question>
                <CodeListRef CodeListOID="CL_259"/>
            </ItemDef>
            <ItemDef OID="I_CCAC_CCA_CONSULT" Name="CCA_CONSULT" DataType="text" Length="14" SASFieldName="CCA_C010" Comment="consultation for illness" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC_1">
                <Question>
                    <TranslatedText>
                    where was he/she taken for consultation?
                    </TranslatedText>
                </Question>
                <OpenClinica:MultiSelectListRef MultiSelectListID="MSL_260"/>
            </ItemDef>
            <ItemDef OID="I_CCAC_CCA_NAME" Name="CCA_NAME" DataType="text" Length="200" SASFieldName="CCA_NAME" Comment="name of the personn for the consultation" OpenClinica:FormOIDs="F_CCAC_2,F_CCAC_1">
                <Question>
                    <TranslatedText>
                    What is the name of this person or clinic/hospital?
                    </TranslatedText>
                </Question>
            </ItemDef>

tomhickerson commented 12 years ago

Hi Mark, just posted the new and old versions with this change applied. Let me know what you think and I can commit to SVN.

mapkon commented 12 years ago

So this didnot fix the issue appropriately. I am more looking at the adjacent questions to CollectionDate? that are grouped together. As long as questions are grouped, they should have the some question structure (item group header, item sub group header + left item text) in the translated text.

tomhickerson commented 12 years ago

I have modified the code and comitted to SVN. The sample result now looks like the following:

<ItemDef OID="I_MLLM_MLL_HIVS_COIDV" Name="MLL_HIVS_COIDv" DataType="date" SASFieldName="MLL_HIVS" Comment="Collection date_HIV_sero" OpenClinica:FormOIDs="F_MLLM5">
<Question OpenClinica:QuestionNumber="Q3a">
<TranslatedText>
Laboratory - HIV-serology - Collection date?
</TranslatedText>
</Question>
</ItemDef>
<ItemDef OID="I_MLLM_MLL_HIVS_RESULTV_568" Name="MLL_HIVS_RESULTv" DataType="float" Length="1" SignificantDigits="1" SASFieldName="MLL_H05w" Comment="HIV viral load result" OpenClinica:FormOIDs="F_MLLM5">
<Question OpenClinica:QuestionNumber="Q3b">
<TranslatedText>
Laboratory - HIV-serology - Result?
</TranslatedText>
</Question>
<CodeListRef CodeListOID="CL_249"/>
</ItemDef>

tomhickerson commented 12 years ago

This was linked with one another by looking at the column_number in the item metadata from the OpenClinica CRF. If the item was given a column_number of 2, the records are linked and the header/subheader from the previous item is used. Please update your code and let me know what you think.

Best, Tom

mapkon commented 12 years ago

I just confirmed this is working. You can close the tickets. Thanks