search

mapkon / oc-conversion-tools

openxdata openclinica form conversion tools
code.openxdata.org
Other
8 stars 4 forks source link

500 error returned from server when subjects do not have DOB specified #94

Closed mapkon closed 12 years ago

mapkon commented 12 years ago

When subjects in openclinica do not have a date of birth specified, the event web service chokes with a 500 status code http error. There should be a way of checking if the date of birth is set or not and return the correct response other than just choking.

tomhickerson commented 12 years ago

Fix committed, please review. Thanks, Tom

mapkon commented 12 years ago

Tom, I have reviewed and it looks like your fix is ok - Is it fine to return null as DOB? Won't it choke like on data upload?

tomhickerson commented 12 years ago

Hi Mark, the WS will only accept null if the study variables are set to not collect DOB for a subject, otherwise, it will return an error to the user. Best, Tom

mapkon commented 12 years ago

Finen - I hope the error is more meaningful. As long as it returns an error and doesnot fall over, then that is acceptable.