maple-labs / trail-of-bits-audit

This repo will be used for all communications between the Maple smart contracts team and the Trail of Bits auditing team.
0 stars 0 forks source link

Proxy CREATE2 determinism improvements PRs #13

Closed lucas-manuel closed 2 years ago

lucas-manuel commented 2 years ago

It was decided that in order to improve the determinism of the proxy addresses, we should give the option to pass in a zero address implementation to the constructor of the proxy, so that in the event that the default version of the implementation changes in the time that it takes the proxy to deploy, it will not affect the address from CREATE2. There are a series of PRs for this change, outlined below.

Currently, they are all pointed at the main branch, as we thought that we could merge these changes first and then rebase the tob-audit/* branches on top of them before getting sign off. If there is another git approach that your team would prefer, please let us know.

PRs (in order of dependencies):