maplestory-music / maplestory-music.github.io

MapleStory Music website
https://maplestory-music.github.io/
MIT License
106 stars 10 forks source link

Allow searching by identifiers. #15

Closed issuefiler closed 1 year ago

issuefiler commented 1 year ago

https://github.com/maplestory-music/maplebgm-db/blob/a4167f754c4e54c493a2478df6e41e05033e5f87/bgm/Bgm42.json#L22

The JSON database has the identifiers (the filenames in the database). Why don’t you enable searching by identifiers with those?

Also, currently it doesn’t show the identifiers, but only the subdirectory names (e.g. “Bgm42”). This piece of information solely doesn’t identify anything. I believe it should show both directory names and identifiers.

issuefiler commented 1 year ago

I guess I’ve just left this issue on a wrong repository; this should be transferred to https://github.com/maplestory-music/maplestory-music.github.io.

nanochromatic commented 1 year ago

Filenames are primarily for recordkeeping. Outside of several exceptions, the filename should be captured by the title and/or description of the song. In the interest of simplicity, there are no plans right now to add filenames to the tabular data on the site.