maplibre / flutter-maplibre-gl

Customizable, performant and vendor-free vector and raster maps, flutter wrapper for maplibre-native and maplibre-gl-js (fork of flutter-mapbox-gl/maps)
https://pub.dev/packages/maplibre_gl
Other
226 stars 125 forks source link

245-hide-info-button #246

Closed JulianBissekkou closed 1 year ago

JulianBissekkou commented 1 year ago

this implements #245

m0nac0 commented 1 year ago

Thank you for the contribution! Have you tried implementing this on the web?

JulianBissekkou commented 1 year ago

Thank you for the contribution! Have you tried implementing this on the web?

@m0nac0 Thanks, I missed this and I will take care of this asap 👍🏽

JulianBissekkou commented 1 year ago

@m0nac0 Web support was added!

JulianBissekkou commented 1 year ago

@m0nac0 Can you check again?

stefanschaller commented 1 year ago

@m0nac0 Is it ready to merge?

stefanschaller commented 1 year ago

@m0nac0 ?

stefanschaller commented 1 year ago

@mariusvn Could you may check that out? @m0nac0 is not responding and we need the fixes.

stefanschaller commented 1 year ago

There is a weird issue with the branch, after moving the app in the background and back to the foreground (resume) on Android.

Explanation: https://www.loom.com/share/e93233eea2af4d59948b90c58b05aff2?sid=a20f5770-6aca-4c16-96a5-82662b234f2b

I'm currently checking out the issue

stefanschaller commented 1 year ago

Working:

    override fun onMapReady(mapboxMap: MapboxMap) {
        val defaultStyle = "https://demotiles.maplibre.org/style.json"

        mapboxMap.setStyle(Style.Builder().fromUri(defaultStyle)) {
            mapboxMap.uiSettings.isAttributionEnabled = true
        }
    }

Not working after onResume

    override fun onMapReady(mapboxMap: MapboxMap) {
        val defaultStyle = "https://demotiles.maplibre.org/style.json"

        mapboxMap.setStyle(Style.Builder().fromUri(defaultStyle)) {
            mapboxMap.uiSettings.isAttributionEnabled = false
        }
    }