maplibre / flutter-maplibre-gl

Customizable, performant and vendor-free vector and raster maps, flutter wrapper for maplibre-native and maplibre-gl-js (fork of flutter-mapbox-gl/maps)
https://pub.dev/packages/maplibre_gl
Other
186 stars 106 forks source link

Update the js dependency in maplibre_gl_web #398

Closed kuhnroyal closed 1 month ago

kuhnroyal commented 2 months ago

There is a 0.7.x version which is used by a lot of packages already. The currently used 0.6.7 version conflicts with this.

josxha commented 1 month ago

Developers are now encoraged to use the package dart:js_interop instead of js:

Important: Prefer using dart:js_interop instead of this package for JS interop. See the JS interop documentation for more details.

kuhnroyal commented 1 month ago

Yes, but this is a pretty simple change to increase the dependency range and publish before introducing breaking changes. I see you creating a lot of PRs with awesome changes, please just keep in mind that this package is used by quite a few people that need an upgrade path.

josxha commented 1 month ago

Yes, but this is a pretty simple change to increase the dependency range and publish before introducing breaking changes.

You're right. It can already be done with a dependency_override but a workaround keeps being a workaround. Making a patch release that bumps depdendencies before breaking changes sounds like a good idea. 👍

I see you creating a lot of PRs with awesome changes, please just keep in mind that this package is used by quite a few people that need an upgrade path.

Could you elaborate a bit pelase? Do you have changelog notes, deprecations or a full migration guide in mind?