search

maplibre / flutter-maplibre-gl

Customizable, performant and vendor-free vector and raster maps, flutter wrapper for maplibre-native and maplibre-gl-js (fork of flutter-mapbox-gl/maps)
https://pub.dev/packages/maplibre_gl
Other
186 stars 106 forks source link

feat!: migrate `maplibre-native` for android to version `11.0.0` (take 2) #406

Closed josxha closed 4 weeks ago

josxha commented 1 month ago

This pull request updates the package to use version 11.0.0 of maplibre-native for android. It superseeds https://github.com/maplibre/flutter-maplibre-gl/pull/403 to make it not dependant on other pull requests.

If wanted, we can change the occurences of "Maplibre" to "MapLibre" to be more in line with maplibre-native. (I'd prefer to do it in a follow-up pr tho).

josxha commented 4 weeks ago

Fixed the version of the MapLibre plugins. There are newer versions for androidx.core:core-ktx too. Should we update it or is it better to keep it on an older version?

kuhnroyal commented 4 weeks ago

We can do that separately.

kuhnroyal commented 4 weeks ago

Sadly I only get black views instead of maps, something is wrong, not sure what.

josxha commented 4 weeks ago

That's strange. It works fine for me on an physical device with android 11. What android version were you testing on?

kuhnroyal commented 4 weeks ago

Only simulator so far, but the main branch works on simulator.

josxha commented 4 weeks ago

Could you check what android or sdk version it's using? Maybe it's related or similar to https://github.com/maplibre/flutter-maplibre-gl/issues/327 which depends on the used OS version.

kuhnroyal commented 4 weeks ago

Dunno why but it is working now :)

kuhnroyal commented 4 weeks ago

And also works on device. I have not reviewed code yet, only tested.

josxha commented 4 weeks ago

Dunno why but it is working now :)

Awesome!👍

josxha commented 4 weeks ago

Thanks again for the help on this pr! (: