Closed kuhnroyal closed 1 month ago
Changes are looking good to me. Two things that could get put into consideration:
fixing the package score by not using library the name for part-of directives. See https://pub.dev/packages/maplibre_gl/score
╷
1 │ part of maplibre_gl;
│ ^^^^^^^^^^^^^^^^^^^^
╵
removing example/pubspec.lock
and scripts/pubspec.lock
files since those files change often and are recommended to be gitignored, see https://dart.dev/guides/libraries/private-files#the-rules pubspec.lock
is already on the gitignore list but the files need to be manual deleted to get ignored.
Changes are looking good to me. Two things that could put into consideration:
- fixing the package score by not using library the name for part-of directives. See pub.dev/packages/maplibre_gl/score
╷ 1 │ part of maplibre_gl; │ ^^^^^^^^^^^^^^^^^^^^ ╵
- removing
example/pubspec.lock
andscripts/pubspec.lock
files since those files change often and are recommended to be gitignored, see dart.dev/guides/libraries/private-files#the-rulespubspec.lock
is already on the gitignore list but the files need to be manual deleted to get ignored.
Yea, there are 26 issues. I'd rather release and fix them in a follow-up release. I am sure something will fail anyways :) This PR is just for getting a baseline published.
Both would get solved in https://github.com/maplibre/flutter-maplibre-gl/pull/401. I'll split the changes into more pull requests, like requested in https://github.com/maplibre/flutter-maplibre-gl/pull/401#issuecomment-2117621794.
About publishing the web package: The package uses resources from the MapTiler CDN at the moment, so I'm not sure if publishing would be good before it gets fixed. See here: https://github.com/maplibre/flutter-maplibre-gl/pull/409
@kuhnroyal Just red https://github.com/maplibre/flutter-maplibre-gl/pull/390#issuecomment-2118171504 and wanted to ask if you consider this 0.9.0 release as a major or minor release?
In flutter prior v1.0.0, a 0.8.0 to 0.9.0 version bump would normally be considered as a major breaking release, while 0.8.0 to 0.8.1 is a feature or minor release.
Or like it ts described in the dart documentation:
Although semantic versioning doesn't promise any compatibility between versions prior to 1.0.0, the Dart community convention is to treat those versions semantically as well. The interpretation of each number is just shifted down one slot: going from 0.1.2 to 0.2.0 indicates a breaking change, going to 0.1.3 indicates a new feature, and going to 0.1.2+1 indicates a change that doesn't affect the public API. For simplicity's sake, avoid using + after the version reaches 1.0.0.
@josxha I'd suggest we merge this and push a release tag to see what fails.
The main idea here is to get a the publishing working with the current state of the project. The
maplibre_gl_web
has never been published. With the new publishing workflow all packages will hopefully be published with a single tag (v0.19.0
in this case).js: ^0.6.7
dependencypubspec_overrides.yaml
files and move overridden local deps there.pubignore
to prevent publishing unnecessary filespubspec.yaml