search

maplibre / flutter-maplibre-gl

Customizable, performant and vendor-free vector and raster maps, flutter wrapper for maplibre-native and maplibre-gl-js (fork of flutter-mapbox-gl/maps)
https://pub.dev/packages/maplibre_gl
Other
185 stars 106 forks source link

chore(example): responsive design #421

Open josxha opened 1 month ago

josxha commented 1 month ago
josxha commented 4 weeks ago

Thanks for the review! I can't test on the iOS Simulator because i don't have a up-to-date mac but I it doesn't crash for me when running on appetize.io (an iOS emulator on the web). Could it be that your problem is related to https://github.com/maplibre/flutter-maplibre-gl/issues/388?

I'd like to do more work on the example app, mostly making it completely responsive. Do you prefer it in multiple pull requests or would one bigger pr be fine for you?

kuhnroyal commented 4 weeks ago

I don't mind bigger PRs for the example app :) That issues you linked is probably the reason, thanks.

josxha commented 4 weeks ago

@kuhnroyal this pull request got big quick 😅 I changed the example app to use Wraps for it's buttons and expanded the map widget for a better experience on large screens. Additionally I moved the buttons to the top to reduce the distance between them and the back button. Still no award-winning layout, but hopefully an improvement. No functionality should have been touched. Let me know if you want anything to get changed.

josxha commented 3 weeks ago

ngx-maplibre-gl has a great showcase: https://maplibre.org/ngx-maplibre-gl/demo/display-map Maybe we can do something similar in the future?