refactor: enable and fix some lint rules

maplibre / flutter-maplibre-gl

Customizable, performant and vendor-free vector and raster maps, flutter wrapper for maplibre-native and maplibre-gl-js (fork of flutter-mapbox-gl/maps)

https://pub.dev/packages/maplibre_gl

Other

185 stars 106 forks source link

refactor: enable and fix some lint rules #452

Closed josxha closed 6 days ago

josxha commented 3 weeks ago

I enabled a bunch of simple lint rules. All those lints in one pull request because it would have been a lot of really small pull requests otherwise. But I created for every lint one commit in case thats better to review.

~~This pull request introduces the following breaking changes:~~

~~Remove the parameter hash from MapOptions because it was not used.~~
~~The parameter type of annotationOrder and annotationConsumeTapEvents from MapLibreMap has changed to a Set.~~

josxha commented 1 week ago

@kuhnroyal I reverted the breaking changes to make this pr code style only. Let me know if you disagree with any or the enabled lint rules. I'd appreciate a code review. (: Or would you prefer to have every rule split in separate pull requests?